Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1367, Add cfe functional tests to CI #1608

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Jun 7, 2021

Describe the contribution
Fixes #1367
Add the functional tests to the CI workflow.

Testing performed
Changed the tests to be wrong and force a failure.
Changed the tests to have a delay to simulate a timeout.

Expected behavior changes
Will now fun the cFE functional tests on every pull request.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

skliper
skliper previously requested changes Jun 7, 2021
cmake/sample_defs/cpu1_cfe_es_startup.scr Outdated Show resolved Hide resolved
.github/workflows/functional-tests.yml Outdated Show resolved Hide resolved
.github/workflows/functional-tests.yml Show resolved Hide resolved
.github/workflows/functional-tests.yml Outdated Show resolved Hide resolved
@zanzaben zanzaben force-pushed the fix1367_add_functional_tests_to_CI branch 3 times, most recently from f31c09f to c6280ab Compare June 11, 2021 15:56
@zanzaben zanzaben force-pushed the fix1367_add_functional_tests_to_CI branch from 358fef6 to fc13fac Compare June 14, 2021 15:10
@zanzaben zanzaben marked this pull request as ready for review June 14, 2021 15:36
@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 14, 2021
@zanzaben zanzaben changed the title WIP Fix #1367, Add cfe functional tests to CI Fix #1367, Add cfe functional tests to CI Jun 15, 2021
@astrogeco
Copy link
Contributor

CCB:2021-06-16 APPROVED

  • Should we modify the cFE assert so that the test log is dumped directly and doesn't depend on the Operating System?
  • Could also set standard output to be synchronous. This only works on Linux

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 16, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate June 17, 2021 09:30
@astrogeco astrogeco dismissed skliper’s stale review June 17, 2021 09:31

Comments addressed

@astrogeco astrogeco merged commit f29151f into nasa:integration-candidate Jun 17, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 21, 2021
nasa/cFE#1630, correct path to users guide warning log

nasa/cFE#1621, add additional test cases for Child Tasks

nasa/cFE#1608, Add cfe functional tests to CI
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 24, 2021
*Combines*

- nasa/elf2cfetbl#81
- nasa/tblCRCTool#52
- nasa/ci_lab#88
- nasa/sch_lab#83
- nasa/sample_app#150
- nasa/sample_lib#64
- nasa/to_lab#100

*Includes*

- nasa/cFE#1630, correct path to users guide warning log
- nasa/cFE#1621, add additional test cases for Child Tasks
- nasa/cFE#1608, Add cfe functional tests to CI
- nasa/cFE#1627, rename/clean CFE coverage assert macros
- nasa/cFE#1623, Added UT tests for cFE ES Api
- nasa/cFE#1634, Expand CDS Functional Tests.
- nasa/cFE#1633, add test log file
- nasa/cFE#1594, Event ID updates
- nasa/cFE#1624, scrub all UT_Report calls

- nasa/osal#1066, implement missing parameter/retcode test permutations

- nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil
- nasa/tblCRCTool#51, add printf conversion casts

** Implement Coding Standard in CodeQL **

- nasa/cFS-GroundSystem#180
- nasa/elf2cfetbl#80
- nasa/tblCRCTool#49

- nasa/ci_lab#87
- nasa/sch_lab#79
- nasa/sample_app#149
- nasa/sample_lib#63
- nasa/to_lab#99
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 24, 2021
*Combines*

- nasa/cFE#1632, v6.8.0-rc1+dev726
- nasa/osal#1079, v5.1.0-rc1+dev548

- nasa/ci_lab#88, v2.4.0-rc1+dev42
- nasa/sch_lab#83, v2.4.0-rc1+dev40
- nasa/sample_app#150, v1.2.0-rc1+dev66
- nasa/sample_lib#64, v1.2.0-rc1+dev38
- nasa/to_lab#100, v2.4.0-rc1+dev49

- nasa/elf2cfetbl#81, v3.2.0-rc1+dev30
- nasa/tblCRCTool#52, v1.2.0-rc1+dev33
- nasa/cFS-GroundSystem#183, v2.2.0-rc1+dev52

*Includes*

- nasa/cFE#1630, correct path to users guide warning log
- nasa/cFE#1621, add additional test cases for Child Tasks
- nasa/cFE#1608, Add cfe functional tests to CI
- nasa/cFE#1627, rename/clean CFE coverage assert macros
- nasa/cFE#1623, Added UT tests for cFE ES Api
- nasa/cFE#1634, Expand CDS Functional Tests.
- nasa/cFE#1633, add test log file
- nasa/cFE#1594, Event ID updates
- nasa/cFE#1624, scrub all UT_Report calls

- nasa/osal#1066, implement missing parameter/retcode test permutations

- nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil
- nasa/tblCRCTool#51, add printf conversion casts

** Implement Coding Standard in CodeQL **

- nasa/cFS-GroundSystem#180
- nasa/elf2cfetbl#80
- nasa/tblCRCTool#49

- nasa/ci_lab#87
- nasa/sch_lab#79
- nasa/sample_app#149
- nasa/sample_lib#63
- nasa/to_lab#99

Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Functional Test to CI
3 participants